Removed GuardClasses package

Updated docker image to 21.6
EventStore · Jul 20, 2021 · 055e7e2 · 055e7e2
1 parent eabdead
commit 055e7e2
Show file tree

Hide file tree

Showing 26 changed files with 126 additions and 104 deletions.
diff --git a/CQRS_Flow/.NET/Carts/Carts.Api.Tests/Carts/InitializingCart/InitializeCartTests.cs b/CQRS_Flow/.NET/Carts/Carts.Api.Tests/Carts/InitializingCart/InitializeCartTests.cs
@@ -21,7 +21,7 @@ public class InitCartFixture: ApiFixture<Startup>
 
         public override async Task InitializeAsync()
         {
-            CommandResponse = await Post(new InitializeCartRequest {ClientId = ClientId });
+            CommandResponse = await Post(new InitializeCartRequest(ClientId));
         }
     }
 

diff --git a/CQRS_Flow/.NET/Carts/Carts.Api/Carts.Api.csproj b/CQRS_Flow/.NET/Carts/Carts.Api/Carts.Api.csproj
@@ -9,12 +9,6 @@
     <ItemGroup>
         <PackageReference Include="Swashbuckle.AspNetCore" Version="6.1.4" />
         <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="5.0.7" />
-        <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="5.0.7">
-          <PrivateAssets>all</PrivateAssets>
-          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-        </PackageReference>
-        <PackageReference Include="Microsoft.EntityFrameworkCore" Version="5.0.7" />
-        <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="5.0.7" />
     </ItemGroup>
 
     <ItemGroup>

diff --git a/CQRS_Flow/.NET/Carts/Carts.Api/Controllers/CartsController.cs b/CQRS_Flow/.NET/Carts/Carts.Api/Controllers/CartsController.cs
@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
-using Ardalis.GuardClauses;
 using Carts.Api.Requests.Carts;
 using Carts.Carts.GettingCartAtVersion;
 using Carts.Carts.GettingCartById;
@@ -27,19 +26,16 @@ public CartsController(
             IQueryBus queryBus,
             IIdGenerator idGenerator)
         {
-            Guard.Against.Null(commandBus, nameof(commandBus));
-            Guard.Against.Null(queryBus, nameof(queryBus));
-            Guard.Against.Null(idGenerator, nameof(idGenerator));
-
             this.commandBus = commandBus;
             this.queryBus = queryBus;
             this.idGenerator = idGenerator;
         }
 
         [HttpPost]
-        public async Task<IActionResult> InitializeCart([FromBody] InitializeCartRequest request)
+        public async Task<IActionResult> InitializeCart([FromBody] InitializeCartRequest? request)
         {
-            Guard.Against.Null(request, nameof(request));
+            if (request == null)
+                throw new ArgumentNullException(nameof(request));
 
             var cartId = idGenerator.New();
 
@@ -54,16 +50,16 @@ public async Task<IActionResult> InitializeCart([FromBody] InitializeCartRequest
         }
 
         [HttpPost("{id}/products")]
-        public async Task<IActionResult> AddProduct(Guid id, [FromBody] AddProductRequest request)
+        public async Task<IActionResult> AddProduct(Guid id, [FromBody] AddProductRequest? request)
         {
-            Guard.Against.Null(request, nameof(request));
-            Guard.Against.Null(request.ProductItem, nameof(request));
+            if (request == null)
+                throw new ArgumentNullException(nameof(request));
 
             var command = Carts.AddingProduct.AddProduct.Create(
                 id,
                 ProductItem.Create(
-                    request.ProductItem.ProductId,
-                    request.ProductItem.Quantity
+                    request.ProductItem?.ProductId,
+                    request.ProductItem?.Quantity
                 )
             );
 
@@ -73,17 +69,17 @@ public async Task<IActionResult> AddProduct(Guid id, [FromBody] AddProductReques
         }
 
         [HttpDelete("{id}/products")]
-        public async Task<IActionResult> RemoveProduct(Guid id, [FromBody] RemoveProductRequest request)
+        public async Task<IActionResult> RemoveProduct(Guid id, [FromBody] RemoveProductRequest? request)
         {
-            Guard.Against.Null(request, nameof(request));
-            Guard.Against.Null(request.ProductItem, nameof(request));
+            if (request == null)
+                throw new ArgumentNullException(nameof(request));
 
             var command = Carts.RemovingProduct.RemoveProduct.Create(
                 id,
                 PricedProductItem.Create(
-                    request.ProductItem.ProductId,
-                    request.ProductItem.Quantity,
-                    request.ProductItem.UnitPrice
+                    request.ProductItem?.ProductId,
+                    request.ProductItem?.Quantity,
+                    request.ProductItem?.UnitPrice
                 )
             );
 
@@ -124,9 +120,11 @@ public Task<IReadOnlyList<CartHistory>> GetHistory(Guid id)
         }
 
         [HttpGet("{id}/versions")]
-        public Task<CartDetails> GetVersion(Guid id, [FromQuery] GetCartAtVersion query)
+        public Task<CartDetails> GetVersion(Guid id, [FromQuery] GetCartAtVersion? query)
         {
-            Guard.Against.Null(query, nameof(query));
+            if (query == null)
+                throw new ArgumentNullException(nameof(query));
+
             return queryBus.Send<GetCartAtVersion, CartDetails>(GetCartAtVersion.Create(id, query.Version));
         }
     }

diff --git a/CQRS_Flow/.NET/Carts/Carts.Api/Requests/Carts/ConfirmCartRequest.cs b/CQRS_Flow/.NET/Carts/Carts.Api/Requests/Carts/ConfirmCartRequest.cs
diff --git a/CQRS_Flow/.NET/Carts/Carts.Api/Requests/Carts/InitializeCartRequest.cs b/CQRS_Flow/.NET/Carts/Carts.Api/Requests/Carts/InitializeCartRequest.cs
@@ -2,8 +2,7 @@
 
 namespace Carts.Api.Requests.Carts
 {
-    public class InitializeCartRequest
-    {
-        public Guid ClientId { get; set; }
-    }
+    public record InitializeCartRequest(
+        Guid? ClientId
+    );
 }
diff --git a/CQRS_Flow/.NET/Carts/Carts.Api/Requests/Carts/ProductItemRequest.cs b/CQRS_Flow/.NET/Carts/Carts.Api/Requests/Carts/ProductItemRequest.cs
@@ -2,10 +2,8 @@
 
 namespace Carts.Api.Requests.Carts
 {
-    public class ProductItemRequest
-    {
-        public Guid ProductId { get; set; }
-
-        public int Quantity { get;  set; }
-    }
+    public record ProductItemRequest(
+        Guid? ProductId,
+        int? Quantity
+    );
 }
diff --git a/CQRS_Flow/.NET/Carts/Carts/Carts.csproj b/CQRS_Flow/.NET/Carts/Carts/Carts.csproj
@@ -13,7 +13,6 @@
     </ItemGroup>
 
     <ItemGroup>
-        <PackageReference Include="Ardalis.GuardClauses" Version="3.2.0" />
         <PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="5.0.0" />
     </ItemGroup>
 

diff --git a/CQRS_Flow/.NET/Carts/Carts/Carts/AddingProduct/AddProduct.cs b/CQRS_Flow/.NET/Carts/Carts/Carts/AddingProduct/AddProduct.cs
@@ -1,7 +1,6 @@
 using System;
 using System.Threading;
 using System.Threading.Tasks;
-using Ardalis.GuardClauses;
 using Carts.Carts.Products;
 using Carts.Pricing;
 using Core.Commands;
@@ -12,7 +11,6 @@ namespace Carts.Carts.AddingProduct
 {
     public class AddProduct: ICommand
     {
-
         public Guid CartId { get; }
 
         public ProductItem ProductItem { get; }
@@ -24,8 +22,8 @@ private AddProduct(Guid cartId, ProductItem productItem)
         }
         public static AddProduct Create(Guid cartId, ProductItem productItem)
         {
-            Guard.Against.Default(cartId, nameof(cartId));
-            Guard.Against.Null(productItem, nameof(productItem));
+            if (cartId == Guid.Empty)
+                throw new ArgumentOutOfRangeException(nameof(cartId));
 
             return new AddProduct(cartId, productItem);
         }

diff --git a/CQRS_Flow/.NET/Carts/Carts/Carts/AddingProduct/ProductAdded.cs b/CQRS_Flow/.NET/Carts/Carts/Carts/AddingProduct/ProductAdded.cs
@@ -1,5 +1,4 @@
 using System;
-using Ardalis.GuardClauses;
 using Carts.Carts.Products;
 using Core.Events;
 
@@ -19,8 +18,8 @@ private ProductAdded(Guid cartId, PricedProductItem productItem)
 
         public static ProductAdded Create(Guid cartId, PricedProductItem productItem)
         {
-            Guard.Against.Default(cartId, nameof(cartId));
-            Guard.Against.Null(productItem, nameof(productItem));
+            if (cartId == Guid.Empty)
+                throw new ArgumentOutOfRangeException(nameof(cartId));
 
             return new ProductAdded(cartId, productItem);
         }

diff --git a/CQRS_Flow/.NET/Carts/Carts/Carts/Cart.cs b/CQRS_Flow/.NET/Carts/Carts/Carts/Cart.cs
@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using Ardalis.GuardClauses;
 using Carts.Carts.AddingProduct;
 using Carts.Carts.ConfirmingCart;
 using Carts.Carts.InitializingCart;
@@ -31,7 +30,7 @@ public static Cart Initialize(
         }
 
         private Cart(){}
-        
+
         public override void When(object @event)
         {
             switch (@event)
@@ -79,9 +78,6 @@ public void AddProduct(
             IProductPriceCalculator productPriceCalculator,
             ProductItem productItem)
         {
-            Guard.Against.Null(productPriceCalculator, nameof(productPriceCalculator));
-            Guard.Against.Null(productItem, nameof(productItem));
-
             if(Status != CartStatus.Pending)
                 throw new InvalidOperationException($"Adding product for the cart in '{Status}' status is not allowed.");
 
@@ -116,8 +112,6 @@ private void Apply(ProductAdded @event)
         public void RemoveProduct(
             PricedProductItem productItemToBeRemoved)
         {
-            Guard.Against.Null(productItemToBeRemoved, nameof(productItemToBeRemoved));
-
             if(Status != CartStatus.Pending)
                 throw new InvalidOperationException($"Removing product from the cart in '{Status}' status is not allowed.");
 

diff --git a/CQRS_Flow/.NET/Carts/Carts/Carts/Config.cs b/CQRS_Flow/.NET/Carts/Carts/Carts/Config.cs
@@ -22,9 +22,8 @@ internal static class CartsConfig
     {
         internal static void AddCarts(this IServiceCollection services)
         {
-            services.AddScoped<IProductPriceCalculator, RandomProductPriceCalculator>();
-
-            services.AddScoped<IRepository<Cart>, EventStoreDBRepository<Cart>>();
+            services.AddScoped<IProductPriceCalculator, RandomProductPriceCalculator>()
+                    .AddScoped<IRepository<Cart>, EventStoreDBRepository<Cart>>();
 
             AddCommandHandlers(services);
             AddProjections(services);

diff --git a/CQRS_Flow/.NET/Carts/Carts/Carts/ConfirmingCart/CartConfirmed.cs b/CQRS_Flow/.NET/Carts/Carts/Carts/ConfirmingCart/CartConfirmed.cs
@@ -1,18 +1,27 @@
 using System;
-using Ardalis.GuardClauses;
 using Core.Events;
 
 namespace Carts.Carts.ConfirmingCart
 {
-    public record CartConfirmed(
-        Guid CartId,
-        DateTime ConfirmedAt
-    ): IEvent
+    public class CartConfirmed: IEvent
     {
+        public Guid CartId { get; }
+
+        public DateTime ConfirmedAt { get; }
+
+        public CartConfirmed(Guid cartId, DateTime confirmedAt)
+        {
+            CartId = cartId;
+            ConfirmedAt = confirmedAt;
+        }
+
         public static CartConfirmed Create(Guid cartId, DateTime confirmedAt)
         {
-            Guard.Against.Default(cartId, nameof(cartId));
-            Guard.Against.Default(confirmedAt, nameof(confirmedAt));
+            if (cartId == Guid.Empty)
+                throw new ArgumentOutOfRangeException(nameof(cartId));
+
+            if(confirmedAt == DateTime.MinValue || confirmedAt == DateTime.MaxValue)
+                throw new ArgumentOutOfRangeException(nameof(confirmedAt));
 
             return new CartConfirmed(cartId, confirmedAt);
         }

diff --git a/CQRS_Flow/.NET/Carts/Carts/Carts/ConfirmingCart/ConfirmCart.cs b/CQRS_Flow/.NET/Carts/Carts/Carts/ConfirmingCart/ConfirmCart.cs
@@ -1,7 +1,6 @@
 using System;
 using System.Threading;
 using System.Threading.Tasks;
-using Ardalis.GuardClauses;
 using Core.Commands;
 using Core.Repositories;
 using MediatR;
@@ -19,7 +18,8 @@ private ConfirmCart(Guid cartId)
 
         public static ConfirmCart Create(Guid cartId)
         {
-            Guard.Against.Default(cartId, nameof(cartId));
+            if (cartId == Guid.Empty)
+                throw new ArgumentOutOfRangeException(nameof(cartId));
 
             return new ConfirmCart(cartId);
         }

diff --git a/CQRS_Flow/.NET/Carts/Carts/Carts/GettingCartAtVersion/GetCartAtVersion.cs b/CQRS_Flow/.NET/Carts/Carts/Carts/GettingCartAtVersion/GetCartAtVersion.cs
@@ -1,7 +1,6 @@
 using System;
 using System.Threading;
 using System.Threading.Tasks;
-using Ardalis.GuardClauses;
 using Carts.Carts.GettingCartById;
 using Core.EventStoreDB.Events;
 using Core.Exceptions;
@@ -23,7 +22,8 @@ private GetCartAtVersion(Guid cartId, ulong version)
 
         public static GetCartAtVersion Create(Guid cartId, ulong version)
         {
-            Guard.Against.Default(cartId, nameof(cartId));
+            if (cartId == Guid.Empty)
+                throw new ArgumentOutOfRangeException(nameof(cartId));
 
             return new GetCartAtVersion(cartId, version);
         }

diff --git a/CQRS_Flow/.NET/Carts/Carts/Carts/GettingCartById/GetCartById.cs b/CQRS_Flow/.NET/Carts/Carts/Carts/GettingCartById/GetCartById.cs
@@ -1,7 +1,6 @@
 using System;
 using System.Threading;
 using System.Threading.Tasks;
-using Ardalis.GuardClauses;
 using Core.ElasticSearch.Indices;
 using Core.Exceptions;
 using Core.Queries;
@@ -20,7 +19,8 @@ private GetCartById(Guid cartId)
 
         public static GetCartById Create(Guid cartId)
         {
-            Guard.Against.Default(cartId, nameof(cartId));
+            if (cartId == Guid.Empty)
+                throw new ArgumentOutOfRangeException(nameof(cartId));
 
             return new GetCartById(cartId);
         }

diff --git a/CQRS_Flow/.NET/Carts/Carts/Carts/GettingCartHistory/GetCartHistory.cs b/CQRS_Flow/.NET/Carts/Carts/Carts/GettingCartHistory/GetCartHistory.cs
@@ -3,13 +3,12 @@
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
-using Ardalis.GuardClauses;
 using Core.Queries;
 using Nest;
 
 namespace Carts.Carts.GettingCartHistory
 {
-    public class GetCartHistory : IQuery<IReadOnlyList<CartHistory>>
+    public class GetCartHistory: IQuery<IReadOnlyList<CartHistory>>
     {
         public Guid CartId { get; }
         public int PageNumber { get; }
@@ -24,14 +23,16 @@ private GetCartHistory(Guid cartId, int pageNumber, int pageSize)
 
         public static GetCartHistory Create(Guid cartId, int pageNumber = 1, int pageSize = 20)
         {
-            Guard.Against.NegativeOrZero(pageNumber, nameof(pageNumber));
-            Guard.Against.NegativeOrZero(pageSize, nameof(pageSize));
+            if (pageNumber <= 0)
+                throw new ArgumentOutOfRangeException(nameof(pageNumber));
+            if (pageSize is <= 0 or > 100)
+                throw new ArgumentOutOfRangeException(nameof(pageSize));
 
             return new GetCartHistory(cartId, pageNumber, pageSize);
         }
     }
 
-    internal class HandleGetCartHistory :
+    internal class HandleGetCartHistory:
         IQueryHandler<GetCartHistory, IReadOnlyList<CartHistory>>
     {
         private readonly IElasticClient elasticClient;
@@ -56,4 +57,4 @@ public async Task<IReadOnlyList<CartHistory>> Handle(GetCartHistory request,
             return result.Documents.ToList();
         }
     }
-}
+}