updates rust to 1.74.0 and fix new clippy errors (#79)

base/src/errors/esc_error.rs

@@ -48,6 +48,7 @@ impl EscError {
     /// Returns the operation error as a Result. The purpose of this is to
     /// make it possible to use the question mark to fetch the actual API
     /// error, and pass back the other error if it was something else.
+    #[allow(clippy::result_large_err)]
     pub fn api_response(self) -> std::result::Result<ApiResponseError, EscError> {
         match self {
             EscError::ApiResponse(err) => Ok(err),

base/tests/error_tests.rs

@@ -2,6 +2,7 @@ use esc_client_base::errors::ApiResponseError;
 use esc_client_base::errors::ProblemDetails;
 use esc_client_base::errors::Result;
 
+#[allow(clippy::result_large_err)]
 fn get_api_error() -> std::result::Result<i32, ApiResponseError> {
     let status_code = reqwest::StatusCode::INTERNAL_SERVER_ERROR;
     let problem_details = ProblemDetails {
@@ -19,11 +20,13 @@ fn get_api_error() -> std::result::Result<i32, ApiResponseError> {
     Err(err)
 }
 
+#[allow(clippy::result_large_err)]
 fn return_error() -> Result<i32> {
     get_api_error()?;
     panic!("get_api_error should have failed");
 }
 
+#[allow(clippy::result_large_err)]
 fn expect_error() -> Result<u16> {
     let result = return_error();
     match result {

rust-toolchain.toml

@@ -1,3 +1,3 @@
 [toolchain]
-channel    = "1.64.0"
+channel    = "1.74.0"
 components = ["rustfmt", "clippy"]

store/src/config/settings.rs

@@ -62,7 +62,7 @@ impl Settings {
                 .source(Box::new(err))
         })?;
 
-        let settings_file = main_settings_file(&settings_dir);
+        let settings_file = main_settings_file(settings_dir);
         tokio::fs::write(settings_file.as_path(), &bytes)
             .await
             .map_err(|err| {