DEV-47 - Retain callback-based subscription APIs alongside AsyncEnumerable APIs #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephcummings
force-pushed
the
DEV-47/revert-subscriptions-obsolete-apis-changes
branch
4 times, most recently
from
69d9fbe
to
74acad4
Compare
josephcummings
force-pushed
the
DEV-47/revert-subscriptions-obsolete-apis-changes
branch
from
74acad4
to
f7eece0
Compare
w1am
approved these changes
May 2, 2024
RagingKore
approved these changes
May 7, 2024
josephcummings
deleted the
DEV-47/revert-subscriptions-obsolete-apis-changes
branch
w1am
pushed a commit
that referenced
this pull request
May 23, 2024
…rable APIs (#297) * Rm Obsolete attributes from older subscriptions APIs * Reorganise obsolete tests to prevent cluttering and make future refactor easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: Removed attributes that marked callback-based subscription APIs as obsolete.
Changed: Moved callback-based tests to Obsolete folders for easier refactoring in future.
The callback-based APIs were previously marked as obsolete, this reverts that so that we can gradually collect feedback on the newer AsyncEnumerable-based APIs prior to removing any existing APIs and impacting users abruptly.
The callback-based APIs will be removed in a future release, providing the AsyncEnumerable-based APIs are suitable as a successor.