-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV-266 - Return null for discovery mode or multiple hosts in connection string #280
Merged
josephcummings
merged 4 commits into
master
from
w1am/dev-266-improve-connectivity-settings-address-resolution-logic
Feb 26, 2024
Merged
DEV-266 - Return null for discovery mode or multiple hosts in connection string #280
josephcummings
merged 4 commits into
master
from
w1am/dev-266-improve-connectivity-settings-address-resolution-logic
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1am
force-pushed
the
w1am/dev-266-improve-connectivity-settings-address-resolution-logic
branch
from
February 6, 2024 06:03
0d0f068
to
0ef472f
Compare
w1am
changed the title
Refactor address resolution logic in connectivity settings
Return null for single host in discovery mode
Feb 6, 2024
w1am
changed the title
Return null for single host in discovery mode
Return null for discovery mode or multiple hosts in connection string
Feb 6, 2024
w1am
force-pushed
the
w1am/dev-266-improve-connectivity-settings-address-resolution-logic
branch
from
February 6, 2024 09:30
0ef472f
to
def981a
Compare
…-address-resolution-logic
josephcummings
previously approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
josephcummings
approved these changes
Feb 6, 2024
RagingKore
approved these changes
Feb 26, 2024
josephcummings
changed the title
Return null for discovery mode or multiple hosts in connection string
DEV-266 - Return null for discovery mode or multiple hosts in connection string
Feb 26, 2024
josephcummings
deleted the
w1am/dev-266-improve-connectivity-settings-address-resolution-logic
branch
February 26, 2024 13:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: Return null for discovery mode or multiple hosts in connection string
Changed: Updated Address field to support null returns
Fixed: #260
This PR refactors the Address property resolution logic in the
EventStoreClientConnectivitySettings
class. Previously, when a cluster was specified in the connection string, the Address property defaulted to localhost:2113, which was inconsistent behavior. With this change, the logic now returns null when a cluster is specified. New tests have also been added to cover various connection string scenarios.Changes