Don't use experimentalVmThreads for vitest when using isolate=false

EvHaus · Aug 2, 2023 · 9998785 · 9998785
1 parent b0634ed
commit 9998785
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/benchmark.yaml b/.github/workflows/benchmark.yaml
@@ -35,6 +35,6 @@ jobs:
           hyperfine --warmup 1 \
           'yarn workspace jasmine test' \
           'yarn workspace jest test' \
-          'yarn workspace vitest test' \
+          'yarn workspace vitest test --experimentalVmThreads' \
           'yarn workspace vitest test --isolate=false' \
           'yarn workspace bun test'
diff --git a/README.md b/README.md
@@ -3,7 +3,7 @@
 This repo is setup to test the performance of various test runners. Specially to:
 
 - Help the **Jest** team with https://github.com/facebook/jest/issues/6694.
-- Help the **Vitest** team with https://github.com/vitest-dev/vitest/issues/229
+- Help the **Vitest** team with https://github.com/vitest-dev/vitest/issues/229 & https://github.com/vitest-dev/vitest/issues/579
 
 ## Setup
 
@@ -16,7 +16,7 @@ yarn
 Then you can run benchmarks via:
 
 ```sh
-hyperfine --warmup 1 'yarn workspace jasmine test' 'yarn workspace jest test' 'yarn workspace vitest test' 'yarn workspace vitest test --isolate=false' 'yarn workspace bun test'
+hyperfine --warmup 1 'yarn workspace jasmine test' 'yarn workspace jest test' 'yarn workspace vitest test --experimentalVmThreads' 'yarn workspace vitest test --isolate=false' 'yarn workspace bun test'
 ```
 
 ## Suites

diff --git a/benchmarks/vitest/vite.config.ts b/benchmarks/vitest/vite.config.ts
@@ -8,7 +8,6 @@ export default defineConfig({
             }
         },
         environment: 'happy-dom',
-        experimentalVmThreads: true,
         setupFiles: ['setupFile.ts'],
         watch: false
     },