Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm): Add util creates for runtime,future and time primitives for wasm #350

Conversation

irvingoujAtDevolution
Copy link
Contributor

This is the second pull request for supporting WASM.

Introducing russh-util crates to encapsulate platform difference.

Prepare for replacing tokio-util, tokio runtime and std::time::Instant::now.

///
/// This type lets you replace the future stored in the box without
/// reallocating when the size and alignment permits this.
pub struct ReusableBoxFuture<'a, T> {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this going to be used?

@@ -0,0 +1,16 @@
use std::future::Future;

pub fn spawn<F>(future: F)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be generic over Output as well, as it's used in various places. I prefer this PR to include the migration of russh and russh-keys over to the generic runtime before merging.

@irvingoujAtDevolution irvingoujAtDevolution marked this pull request as draft September 20, 2024 17:59
@Eugeny Eugeny closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants