Add support for glob pattern matching in Host directives #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
packetsource
commented
Jun 28, 2024
packetsource
commented
- update parse logic to perform host glob matching (using globset)
- generalise token expansion so it can be used to qualify hosts as well as localising ProxyCommand
- add proxyjump to the config structure
- generalise token expansion so it can be used to qualify hosts as well as localising ProxyCommand - add proxyjump to the config structure
|
Thank you! @all-contributors please add @packetsource for code |
|
I've put up a pull request to add @packetsource! 🎉 |
Eugeny
pushed a commit
that referenced
this pull request
Jul 4, 2024
Adds @packetsource as a contributor for code. This was requested by Eugeny [in this comment](#306 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Eugeny
pushed a commit
that referenced
this pull request
Aug 24, 2024
PR #306 broke russh config parsing for me. My ssh config looks roughly like this: ``` Host * Common settings Host wanted Host-specific settings ``` Before #306 common settings were ignored, but after - common settings were applied, yet config parser stops right on next `Host` section start, so settings I need were ignored instead. This PR brings behavior closer to what openssh itself does - for requested host, it applies all the settings with maching glob, not only the first one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.