-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Augment reality to show tabletop scene #303
Augment reality to show tabletop scene #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sample works well @TADraeseke 💯
Just a few suggestion changes and one error-handling comment.
samples/augment-reality-to-show-tabletop-scene/augment-reality-to-show-tabletop-scene.png
Outdated
Show resolved
Hide resolved
samples/augment-reality-to-show-tabletop-scene/build.gradle.kts
Outdated
Show resolved
Hide resolved
...c/main/java/com/esri/arcgismaps/sample/augmentrealitytoshowtabletopscene/DownloadActivity.kt
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/esri/arcgismaps/sample/augmentrealitytoshowtabletopscene/MainActivity.kt
Outdated
Show resolved
Hide resolved
.../sample/augmentrealitytoshowtabletopscene/screens/AugmentRealityToShowTabletopSceneScreen.kt
Show resolved
Hide resolved
.../sample/augmentrealitytoshowtabletopscene/screens/AugmentRealityToShowTabletopSceneScreen.kt
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/esri/arcgismaps/sample/augmentrealitytoshowtabletopscene/MainActivity.kt
Outdated
Show resolved
Hide resolved
…om/esri/arcgismaps/sample/augmentrealitytoshowtabletopscene/DownloadActivity.kt Co-authored-by: Shubham Sharma <[email protected]>
Co-authored-by: Shubham Sharma <[email protected]>
Co-authored-by: Shubham Sharma <[email protected]>
…om/esri/arcgismaps/sample/augmentrealitytoshowtabletopscene/screens/AugmentRealityToShowTabletopSceneScreen.kt Co-authored-by: Shubham Sharma <[email protected]>
…om/esri/arcgismaps/sample/augmentrealitytoshowtabletopscene/screens/AugmentRealityToShowTabletopSceneScreen.kt Co-authored-by: Shubham Sharma <[email protected]>
Co-authored-by: Shubham Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TADraeseke Generally looks good. However, I notice that you don't use the onInitializationStatusChanged
callback to display information to the user. Swift doesn't require this because they have access to a built-in coaching overlay from ARKit. However, we don't have such a thing in ARCore, so the microapp in the toolkit repo uses the onInitializationStatusChanged
callback to tell the user to move their phone around until a plane is detected, then to tap on the plane to place a scene. Was this a deliberate decision not to include this workflow?
Note: TableTopSceneView
also has another new piece of API requestCameraPermissionAutomatically
. I don't know if this is worth mentioning in the sample README
...e/src/main/java/com/esri/arcgismaps/sample/augmentrealitytoshowtabletopscene/MainActivity.kt
Outdated
Show resolved
Hide resolved
.../sample/augmentrealitytoshowtabletopscene/screens/AugmentRealityToShowTabletopSceneScreen.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: hud10837 <[email protected]>
Co-authored-by: hud10837 <[email protected]>
Thanks @hud10837 -- added some instructions back in using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
.../sample/augmentrealitytoshowtabletopscene/screens/AugmentRealityToShowTabletopSceneScreen.kt
Outdated
Show resolved
Hide resolved
…om/esri/arcgismaps/sample/augmentrealitytoshowtabletopscene/screens/AugmentRealityToShowTabletopSceneScreen.kt Co-authored-by: hud10837 <[email protected]>
Thanks @hud10837! |
Description
PR to add a new Kotlin sample Augment reality to show tablestop scene in Augmented reality category.
Links and Data
What To Review
How to Test
Run the sample with your device