-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
popup: Implement TextPopupElement view for MAUI #522
Conversation
"Margin" was causing content to shift and clip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great. Really only found one minor oversight
|
||
case MarkupType.Image: | ||
var imageElement = new Image(); | ||
if (Uri.TryCreate(node.Content, UriKind.Absolute, out var imgUri)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that his can also begin with data:image/
. See
arcgis-maps-sdk-dotnet-toolkit/src/Toolkit/Toolkit/UI/Controls/PopupViewer/PopupMediaView.cs
Lines 89 to 92 in 1e8ad8a
if (sourceUrl.StartsWith("data:image/")) | |
{ | |
// might be base64 | |
var idx = sourceUrl.IndexOf(";base64,"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on iOS and everything looks good except for cases where a popup contains nothing but text-only TextPopupElements. In cases like that, ScrollView does not correctly expand to show contents, and stays collapsed: This is not a regression in this PR -- it's probably due to a MAUI bug dotnet/maui#15374 |
TextElementPopupView is coming to MAUI!
Known limitations
<sub>
) and superscript (<sup>
) do not have any visual effect, because MAUI does not expose any API to control this font feature.