Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AR updates for Android #395

Merged
merged 6 commits into from
Jan 4, 2022
Merged

AR updates for Android #395

merged 6 commits into from
Jan 4, 2022

Conversation

nCastle1
Copy link
Contributor

The changes in this PR should resolve the following issues:

Summary of changes:

  • Update AR Core to 1.26.0
  • Update SceneForm to 1.17.1 (last release before deprecation)
  • Updates ARSceneView to destroy resources in OnDetachedFromWindow; testing shows that this seems to work well when navigating between activities within and app, and when switching between apps. This resolves an issue with the camera feed not rendering in some cases.
  • Updates the hit test implementation, because hit testing stopped working with the new dependencies, possibly related to trackable is not a Plane xamarin/XamarinComponents#1305, but more testing is needed to confirm

Risks/things to look out for:

  • hit test behavior has changed significantly; this more or less matches the native Android implementation, so it should be fine. It does look like results are less predictable in testing, but it isn't clear if that is driven by the hit test implementation changes, or changes to AR Core
  • AR Core has updated plane detection and configuration options. In at least one test run, it was detecting vertical planes; I wasn't able to repro, but worth considering if vertical plane detection should be on by default.

dotMorten and others added 5 commits December 1, 2021 13:18
This change makes AR more reliable in cases where multiple AR SceneViews are displayed within an app session.
This change better matches the native Android/kotlin AR toolkit implementation. Native Android's implementation ignores rotation, so it isn't a perfect match.

This change was made because hit testing stopped working after updating the ARCore dependencies. xamarin/XamarinComponents#1305 Seems potentially related
Base automatically changed from v100.13 to main December 15, 2021 19:05
@nCastle1 nCastle1 marked this pull request as ready for review December 19, 2021 21:43
@nCastle1 nCastle1 merged commit 13e8be5 into main Jan 4, 2022
@nCastle1 nCastle1 deleted the ncastle/v13-ar branch March 17, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants