perf: improve poseidon2 time by 2 times #739
Merged
+65
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #738
This PR:
.pow(5)
to significantly cut down permutation costFlamegraph
Download this: cargo 2025-01-14 16.20 profile.json
Go to
https://profiler.firefox.com
and load this file (which you can hover around to see the percentage clearly). Alternatively, see the below screenshot:Right now, the new dominant cost leader isMulAssign
which I don't think we can cut further, but I still didn't quite achieve the same performance than the paper reported, still a (7.2-6.5) gap for bls12, with t=2.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
CHANGELOG.md
of touched crates.Files changed
in the GitHub PR explorer