Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove grcov from nix flake #656

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix: remove grcov from nix flake #656

merged 2 commits into from
Aug 15, 2024

Conversation

ggutoski
Copy link
Contributor

closes: #655

This PR:

This PR does not:

Key places to review:


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added relevant changelog entries to the CHANGELOG.md of touched crates.
  • Re-reviewed Files changed in the GitHub PR explorer

@ggutoski ggutoski requested review from alxiong and mrain as code owners August 15, 2024 17:37
@ggutoski ggutoski merged commit 92714a4 into main Aug 15, 2024
5 checks passed
@ggutoski ggutoski deleted the gg/655 branch August 15, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nix broken by grcov + Rust 1.80
2 participants