fix: Merkle tree bug fix #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
previously approved these changes
Feb 27, 2024
jbearer
previously approved these changes
Feb 27, 2024
ggutoski
approved these changes
Feb 27, 2024
Comment on lines
+291
to
+303
| } else if num_leaves == 0 { | ||
| Ok((Arc::new(MerkleNode::<E, u64, T>::Empty), height, 0)) | ||
| } else if height == 0usize { | ||
| Ok(( | ||
| Arc::new(MerkleNode::Leaf { | ||
| value: H::digest_leaf(&0, leaves[0].borrow())?, | ||
| pos: 0, | ||
| elem: leaves[0].borrow().clone(), | ||
| }), | ||
| height, | ||
| 1, | ||
| )) | ||
| } else { |
Comment on lines
+177
to
+180
| // singleton merkle tree test (#499) | ||
| let mt = RescueLightWeightMerkleTree::<F>::from_elems(None, [F::from(0u64)]).unwrap(); | ||
| let (elem, _) = mt.lookup(0).expect_ok().unwrap(); | ||
| assert_eq!(elem, &F::from(0u64)); |
Comment on lines
-7
to
-10
| cargo +nightly test --release -p jf-utils -- -Zunstable-options --report-time | ||
| cargo +nightly test --release -p jf-plonk --lib --bins -- -Zunstable-options --report-time | ||
| cargo +nightly test --release -p jf-primitives --features test-srs -- -Zunstable-options --report-time # enable test-srs feature for gen_srs_for_testing | ||
| cargo +nightly test --release -p jf-relation -- -Zunstable-options --report-time |
There was a problem hiding this comment.
thanks for removing nightly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #499
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer