Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix broken by grcov + Rust 1.80 #655

Closed
ggutoski opened this issue Aug 15, 2024 · 0 comments · Fixed by #656
Closed

Nix broken by grcov + Rust 1.80 #655

ggutoski opened this issue Aug 15, 2024 · 0 comments · Fixed by #656
Assignees
@ggutoski
Labels
jf-vid-prep-audit-benches

Comments

@ggutoski
Copy link
Contributor

Can't update nix because grcov is broken on Rust 1.80. See mozilla/grcov#1187 (comment) . The fix PR has been open for over a month: mozilla/grcov#1188 .

Seems that the easiest solution is to simply remove grcov from the nix flake. It's used only for test coverage. The only problem caused by its removal is that scripts/test_coverage.sh will break. That's a price I'm willing to pay until such time as grcov is fixed.
@ggutoski ggutoski self-assigned this Aug 15, 2024
@ggutoski ggutoski changed the title Nix broken by Rust 1.80 Nix broken by grcov + Rust 1.80 Aug 15, 2024
@ggutoski ggutoski mentioned this issue Aug 15, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggutoski ggutoski

Labels
jf-vid-prep-audit-benches
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove grcov from nix flake EspressoSystems/jellyfish
2 participants
@philippecamacho @ggutoski