Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VID ADVZ check consistency of multiplicity in verify_share #653

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

ggutoski
Copy link
Contributor

closes: #644

This PR:


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added relevant changelog entries to the CHANGELOG.md of touched crates.
  • Re-reviewed Files changed in the GitHub PR explorer

@ggutoski ggutoski requested a review from akonring as a code owner August 14, 2024 19:07
vid/src/advz.rs Show resolved Hide resolved
@akonring
Copy link
Contributor

akonring commented Aug 15, 2024

Yes, I believe I put those comments there because we don't actually check consistency with the merkle root for all the evaluations in a share (with multiplicity). The share only contains the merkle path for the first evaluation.

My memory fails my as to why I did not implement this check in the first place. At that point we were considering "batching" the KZG evals which might be the reason that the implementation was postponed.

Created an issue here: #654. Feel free to modify.

@ggutoski ggutoski merged commit f3ef0b9 into main Aug 15, 2024
5 checks passed
@ggutoski ggutoski deleted the gg/644 branch August 15, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A multiplicity different than expected can cause nodes to panic.
2 participants