Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VID: verify consistency with the merkle root for all the evaluations in a VID share #654

Closed
akonring opened this issue Aug 15, 2024 · 0 comments · Fixed by #657
Closed
Assignees
Labels
crypto Crypto team tasks (PM purpose) jf-vid-prep-audit-benches T-bug Type: bug vid

Comments

@akonring
Copy link
Contributor

akonring commented Aug 15, 2024

Discussion of issue here: #653 (comment)

We don't check consistency with the merkle root for all the evaluations in a share (with multiplicity). The share only contains the merkle path for the first evaluation.

If we consider doing KZG eval batching in the future, we should represent the VID share such that consistency check with the merkle root can be done for all evaluations still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Crypto team tasks (PM purpose) jf-vid-prep-audit-benches T-bug Type: bug vid
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants