-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notification hint to bypass dnd/inhibition #334
Conversation
5b06e20
to
408e91d
Compare
Have you tried changing the I like the massive simplification that you made so I'll at least merge that if not also the new param if the config change doesn't work out :) |
Oh I didn't know about Should I add documentation for this hint, or would you rather do it yourself? |
What I meant was that |
My previous message wasn't very clear. I meant to say that I see value in making the two mechanisms separate. For example, let's say I want critical notifications that linger on screen indefinitely AND have custom notifications bypass dnd while honoring the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the dialog and I agree with you, thanks :)
Oh wait, the linter is failing, could you fix that real? |
408e91d
to
77bc617
Compare
Should be good now :D |
I use a couple scripts that trigger custom transient notifications using notify-send (e.g cycling through MPRIS players using playerctld). When I enable dnd, it unfortunately hides those notifications as well :(
I tried using
notify-send --urgency critical
, but critical notifications never expire (it overrides--expire-time
). I tried closing the notification via dbus after asleep
, but that gets very messy very quickly.Instead, I opted to add a hint to bypass swaync's dnd/inhibit mechanisms. It can be used like this:
notify-send \ --expire-time 1000 \ --transient \ --hint boolean:SWAYNC_BYPASS_DND:true \ "hello"
Let me know what you think 😃
Oh also, should I add this to the manpage/readme? If so, where?