Add toggle button #304
Add toggle button #304
Conversation
|
LMK when you want a review :) |
Should be ready now :) |
|
Sorry for the delay, I've been in the process of moving so haven't really had any time for reviewing. I'll take a look at this tomorrow when I'm a bit more awake. Don't be afraid to ping me if I forget :) |
No worries, don't have a lot of time myself at the moment. It might take me a couple of weeks to find the time and look at the comments :) |
JannisPetschenka
force-pushed
the
main
branch
from
fdc951e to
ceb2248
Compare
JannisPetschenka
force-pushed
the
main
branch
2 times, most recently
from
09bfebb to
57371ea
Compare
JannisPetschenka
force-pushed
the
main
branch
from
57371ea to
6dafd54
Compare
added this. So should be ready now :) |
No worries :) |
Same here... I think that uncrustify is the only formatter that works with vala... I'm kinda starting to regret using vala... 😅 I might wanna start discussing #76 again |
|
Done! :)
Yeah, and the ls for vala is kinda annoying (at least on my setup) 🙃 |
Issue #284
Had some spare time :)
The only issue I see is that the button doesn't "poll" for changes, so if you change the button-state from outside swaync the button stays active/non-active and would be out of sync 🙃 Don't know what the best way to go about that would be :)