Workarounds for Node Build Issues #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a workaround for npm/cli#7657 at this point, yet does not fix release builds until we can find a base image for 22.4.x Also changes the name as there no longer is Docker involved.
This fixes our docker builds until Node fixes their issue.
Epse
force-pushed
the
remove-docker-from-pr-ci
branch
from
5fb564c
to
cc1e904
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 22.5 was released recently and introduced npm/cli#7657
This causes our PR and release builds to fail.
As a workaround, we pin the docker builds to the (now unsupported) 22.4 base image,
and switch the PR action to a plain Node operation.