Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trie try #1374

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Trie try #1374

wants to merge 16 commits into from

Conversation

tgymnich
Copy link
Member

No description provided.

wsmoses
wsmoses reviewed Aug 11, 2023
View reviewed changes
enzyme/Enzyme/TypeAnalysis/Trie.h
private:
int depth;
bool is_leaf;
std::map<int, Trie *> mapping;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be shared ptr

tgymnich
tgymnich commented Aug 11, 2023
View reviewed changes
enzyme/Enzyme/TypeAnalysis/Trie.h
private:
int depth;
bool is_leaf;
std::map<int, Trie *> mapping;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a shared_ptr

@tgymnich tgymnich closed this Aug 12, 2023
@tgymnich tgymnich reopened this Aug 12, 2023
@tgymnich tgymnich closed this Dec 16, 2023
@wsmoses wsmoses reopened this Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmoses wsmoses wsmoses left review comments

@ZuseZ4 ZuseZ4 ZuseZ4 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgymnich @wsmoses @ZuseZ4