1.11: more methodinstance stuff #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Oct 21, 2024
| if Base.isdispatchtuple(sig) # JuliaLang/julia#52233 | ||
| return GPUCompiler.methodinstance(ft, tt, world) | ||
| else | ||
| return prevmethodinstance(ft, tt, world) |
There was a problem hiding this comment.
You just want to call mi = Core.Compiler.specialize_method(mi.def, sig, mi.sparam_vals)::MethodInstance in this case, but you need a call to which to obtain def
There was a problem hiding this comment.
Edit: Maybe? This is all pretty much unsound.
There was a problem hiding this comment.
I mean happy to defer that to the experts, it's now just falling back to the old implementation
There was a problem hiding this comment.
Old from 1.10 in gpucompiler*** while concurrently I opened a PR to gpucompiler jl to actually fix and not have us have to vendor it
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.