update envo-edit.owl to include ARMS related classes #1440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cpavloud the definitions don't follow our guidance (see the ENVO wiki), which also makes thr placement of these terms a bit odd. Would you like some help? |
|
Aside from the build break, many of these classes are overspecified and seem more appropriate as instances of more generic classes |
|
@cpavloud would you like any help with this PR? |
Merged
|
Retiring this. Adding these terms with modifications in #1537. These are very specific classes, so the labels will reflect that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pbuttigieg here is the new term for ARMS (#1402 ) and its subclasses. :)