Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions CI #32

Merged
merged 4 commits into from
Dec 29, 2021
Merged

Add GitHub Actions CI #32

merged 4 commits into from
Dec 29, 2021

Conversation

zmughal
Copy link
Member

@zmughal zmughal commented Dec 29, 2021

Fixes #31.

@zmughal
Add GitHub Actions
7a6a0bc 
Fixes <#31>.
@zmughal
Disable parallel build
ecfaace 
Dependency `Sereal::Encoder` can not currently build in parallel.

Related to issue <Sereal/Sereal#260>.
@zmughal
Copy link
Member Author

zmughal commented Dec 29, 2021 •
edited
Loading

Regarding the issue with S::K::Try, perhaps using https://metacpan.org/pod/Feature::Compat::Try with Perl 5.34 will get the coverage to run.

@zmughal
Copy link
Member Author

zmughal commented Dec 29, 2021

The .csv suffix appears necessary for Windows otherwise the tempfile will intermittently fail with a "Permission denied" error.

@zmughal zmughal requested review from iynehz and mohawk2 December 29, 2021 11:11
@mohawk2 mohawk2 merged commit 0dd5f25 into master Dec 29, 2021
@mohawk2 mohawk2 deleted the 31-gha branch December 29, 2021 18:58
@zmughal
Copy link
Member Author

zmughal commented Dec 31, 2021

Regarding code coverage, from my investigations, I think there is a Devel::Cover bug that needs to be addressed before it can be enabled again. Possibly pjcj/Devel--Cover#175. For now the branch https://github.com/EntropyOrg/p5-Data-Frame/compare/use-fc-try is a WIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohawk2 mohawk2 mohawk2 approved these changes

@iynehz iynehz Awaiting requested review from iynehz

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to Github Actions
2 participants
@zmughal @mohawk2