Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Delegate modal dialog #3573

Merged
merged 10 commits into from
Jul 13, 2024
Merged

fix: Delegate modal dialog #3573

merged 10 commits into from
Jul 13, 2024

Conversation

SorinC6
Copy link
Contributor

@SorinC6 SorinC6 commented Jul 4, 2024 •
edited
Loading

@emurgo-rnd
Copy link

YOEXT-1225: Staking. Delegate modal window appears every time user opens the Staking page.

@SorinC6 SorinC6 changed the title change config when cancel dialog fix: Delegate modal dialog Jul 4, 2024
@SorinC6 SorinC6 requested a review from Nebyt July 4, 2024 13:15
Nebyt
Nebyt previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. 🚀

@Nebyt Nebyt self-requested a review July 9, 2024 12:11
Nebyt
Nebyt previously approved these changes Jul 9, 2024
View reviewed changes
@SorinC6
Copy link
Contributor Author

SorinC6 commented Jul 9, 2024

/check

@SorinC6 SorinC6 self-assigned this Jul 9, 2024
SorinC6
SorinC6 commented Jul 9, 2024
View reviewed changes
Copy link
Contributor Author

@SorinC6 SorinC6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@Nebyt Nebyt self-requested a review July 9, 2024 13:19
Nebyt
Nebyt previously approved these changes Jul 9, 2024
View reviewed changes
@vsubhuman vsubhuman added this to the 5.2.200 milestone Jul 12, 2024
@SorinC6 SorinC6 changed the base branch from develop to production July 12, 2024 13:31
@SorinC6 SorinC6 dismissed Nebyt’s stale review July 12, 2024 13:31

The base branch was changed.

@SorinC6 SorinC6 changed the base branch from production to develop July 12, 2024 13:33
@vsubhuman vsubhuman changed the base branch from develop to production July 13, 2024 10:28
vsubhuman
vsubhuman previously approved these changes Jul 13, 2024
View reviewed changes
@vsubhuman vsubhuman changed the base branch from production to release/5.2.200 July 13, 2024 10:31
@vsubhuman vsubhuman dismissed their stale review July 13, 2024 10:31

The base branch was changed.

@vsubhuman vsubhuman mentioned this pull request Jul 13, 2024
Merged
2 tasks
@vsubhuman vsubhuman merged commit d5116e7 into release/5.2.200 Jul 13, 2024
6 of 7 checks passed
@vsubhuman vsubhuman deleted the sorin/YOEXT-1225/fix-modal branch July 13, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsubhuman vsubhuman vsubhuman approved these changes

@Nebyt Nebyt Nebyt left review comments

Assignees

@SorinC6 SorinC6

Labels
None yet
Projects
None yet
Milestone
5.2.200
Development

Successfully merging this pull request may close these issues.
4 participants
@SorinC6 @emurgo-rnd @vsubhuman @Nebyt