Use Chrome manifest V3 #2965
Merged
Use Chrome manifest V3 #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yushih
force-pushed
the
yushi/manifest-v3
branch
from
507f04f
to
82cd0c0
Compare
yushih
force-pushed
the
yushi/manifest-v3
branch
from
172f953
to
ed2fefa
Compare
a-hosani
approved these changes
Jan 7, 2023
yushih
commented
Aug 4, 2023
| } catch (e) { | ||
| console.error(`[yoroi/${YOROI_TYPE}] injection failed!`, e); | ||
| reject(e); | ||
| resolve(false); |
There was a problem hiding this comment.
Yes. This change is valid. reject(e) was wrong.
yushih
commented
Aug 4, 2023
vsubhuman
approved these changes
Aug 21, 2023
|
SonarQube Quality Gate
See analysis details on SonarQube Fix issues before they fail your Quality Gate with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://emurgo.atlassian.net/browse/YOEXT-125
See the comment of https://emurgo.atlassian.net/wiki/spaces/YE/pages/739311617/Checklist+to+upgrade+to+manifest+v3 for documentation.
Notes to developers:
Originally, the dev server is started by running:
Now, this command still works for backward compatibility, but it is recommend to run
and
separately in two consoles.
Notes to release manager:
The originally commands all build mv3 packages.
To build mv2 packages (for Firefox), use:
and