[drft] drp xtndd #700
Closed
[drft] drp xtndd #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisicky
reviewed
Nov 11, 2024
| @@ -29,6 +30,93 @@ pub enum DRepKind { | |||
| AlwaysNoConfidence, | |||
| } | |||
|
|
|||
| #[wasm_bindgen] | |||
| #[derive(Clone, Debug, Hash, Eq, Ord, PartialEq, PartialOrd)] | |||
| pub enum DRepExtendedId { | |||
There was a problem hiding this comment.
My suggestion to fully implement CIP-129 GovernanceIdentifier to not have N implementations of different things that just are subset of GovernanceIdentifier
lisicky
reviewed
Nov 11, 2024
| self.internal_to_bech32("drep".to_string()) | ||
| } | ||
|
|
||
| pub fn to_bech32_cip129(&self) -> Result<String, JsError> { |
There was a problem hiding this comment.
probably we need to encode only in cip129 format and do not provide API to encode in a old format when cip129 will be merged
|
After additional discussing it was agreed to take a different approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.