Can't create any overview or landing page

[vasiok32k]

Hello
After installing the module but was found issues during creating landing page and overview page, after click on button Save or Save and Continue Edit, page will be frozen and got error in the console related of Page Builder

I partly investigated issue and it seems like it's caused by wrong component structure, a component within a component that can't handle a component. As a solution could be that move Page Builder instances behind the button that will need to click a button to open the Page Builder - need to add that config line in appropriate places where adding Page Builder instances:

<item name="pagebuilder_button" xsi:type="boolean">true</item>

It will solve the problem but will lead to another PHP error like this:

Could you please fix that issues or at least tell me please how to could be resolved?

[edwinljacobs]

Hi,

I assume you are on enterprise? Which version exactly? To be honest i'm not sure why this is an issue. I would have to investigate that, sadly I cannot do that today. I think I will be able to provide you with an update on Wednesday. By the way, I assume you are using this in combination with tweakwise?

I did take a quick look to find similar issues, maybe this helps in the meantime? mirasvit/module-blog#162

With kind regards

[vasiok32k]

Version is 2.3.5-p2

[vasiok32k]

I will really appreciate you if you will help me to fix it (about that link - I already looked that resource before and it not helped me unfortunately)

[edwinljacobs]

Hi,

I took a quick look, It seems that we have been sloppy with our method definition in
Emico\AttributeLanding\Model\IrlRewriteService::generateRewrite();

diff --git a/src/Model/UrlRewriteService.php b/src/Model/UrlRewriteService.php
index 0d0650f..b22c72c 100644
--- a/src/Model/UrlRewriteService.php
+++ b/src/Model/UrlRewriteService.php
@@ -109,10 +109,10 @@ class UrlRewriteService
     }
 
     /**
-     * @param LandingPage $page
+     * @param UrlRewriteGeneratorInterface $page
      * @param string|null $suffix
      */
-    public function generateRewrite(LandingPage $page, string $suffix = null)
+    public function generateRewrite(UrlRewriteGeneratorInterface $page, string $suffix = null)
     {
         $urlRewritesToPersist = [];

You could try to apply this patch and check if that works (I haven't tested it). The overview page functionality is seldom used and perhaps under developed.... Ill look into this with more detail wednesday.

With kind regards

[edwinljacobs]

I made a note for testcases as this kind of stuff should not happen

[vasiok32k]

Thanks seems like it helps for overview page, but landing page still can't be save, getting that error

[vasiok32k]

Will wait Wednesday

[edwinljacobs]

Hi,

I created release https://github.com/EmicoEcommerce/Magento2AttributeLanding/releases/tag/v1.1.3 for this issue.
It should be fixed now. One thing though, I assume you are using this module in combination with
https://github.com/EmicoEcommerce/Magento2Tweakwise
https://github.com/EmicoEcommerce/Magento2TweakwiseExport
https://github.com/EmicoEcommerce/Magento2AttributeLandingTweakwise

The reason I'm asking is that if this is not the case then it wont work. The mechanism that should apply the filters in the field Filter attributes (in the form above) to the product list is not implemented in native magento. See

Magento2AttributeLanding/src/Model/FilterApplier/MagentoFilterApplier.php

Line 24 in 055f632

//@todo Magento native implementation for applying filters

[vasiok32k]

Hi
Thanks a lot for you time, seems like it fixed and works well.
I also created PR about error related of Page Builder, please review it and merge if it acceptable for you (because moving Page Builder instances behind the buttons really fixing that problem)
#18

[edwinljacobs]

Thanks for taking the time to make a PR! it has been released in https://github.com/EmicoEcommerce/Magento2AttributeLanding/releases/tag/v1.1.4

I hope this solves your issues, good luck!

[vasiok32k]

Yes, it solved my issues, thanks for your activities and help.

[vasiok32k]

Tell me please how to became a contributor to be in this list?

[edwinljacobs]

Yeah weird, that doesn't work, perhaps https://stackoverflow.com/questions/40644933/not-showing-as-a-contributor-on-github helps, the accepted answer is not applicable but maybe something in your email settings (the second answer)?

[vasiok32k]

Hi
I contacted with support of the Github and we resolved the problem, thanks.