Fix for #17, fixed undefined index error when no filters are selected…

…, fixed type error in url rewrite generator
EmicoEcommerce · Nov 18, 2020 · 055f632 · 055f632
1 parent 3d5c2d5
commit 055f632
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/Controller/Adminhtml/Page/Save.php b/src/Controller/Adminhtml/Page/Save.php
@@ -121,6 +121,7 @@ protected function hydrateLandingPage(LandingPageInterface $landingPage, array $
             unset($data[LandingPageInterface::OVERVIEW_PAGE_IMAGE]);
         }
         $this->dataObjectHelper->populateWithArray($landingPage, $data, LandingPageInterface::class);
-        $landingPage->setFilterAttributes(serialize($data[LandingPageInterface::FILTER_ATTRIBUTES]));
+        $filterAttributes = $data[LandingPageInterface::FILTER_ATTRIBUTES] ?? [];
+        $landingPage->setFilterAttributes(serialize($filterAttributes));
     }
 }
diff --git a/src/Model/UrlRewriteService.php b/src/Model/UrlRewriteService.php
@@ -109,10 +109,10 @@ static function (UrlRewrite $rewrite) {
     }
 
     /**
-     * @param LandingPage $page
+     * @param UrlRewriteGeneratorInterface $page
      * @param string|null $suffix
      */
-    public function generateRewrite(LandingPage $page, string $suffix = null)
+    public function generateRewrite(UrlRewriteGeneratorInterface $page, string $suffix = null)
     {
         $urlRewritesToPersist = [];