Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a solution for additional license exceptions. #545

Merged
merged 2 commits into from
Sep 3, 2023

Conversation

dsully
Copy link
Contributor

@dsully dsully commented Aug 4, 2023

Implement a solution for additional license exceptions configuration as described in #541

Happy to entertain other solutions or approaches.

Minor typo fixed as well.

@Jake-Shadle
Copy link
Member

Apologies for taking so long to look at this!

I think the code in this would work to solve the immediate use case you have, but I'm worried if I accept it it would make adding a more general layered configuration system, similar to what cargo has, more difficult in the future. But I suppose I can accept it for now, just with the understanding if that layered configuration system is done in the future you will need to migrate to the new one, which is probably fine since since I don't think many people will use it.

Implement a solution for additional license exceptions configuration
as described in EmbarkStudios#541
@mergify mergify bot merged commit 30fb0d0 into EmbarkStudios:main Sep 3, 2023
9 checks passed
@dsully
Copy link
Contributor Author

dsully commented Sep 3, 2023

Thanks - I agree that the layered approach is better, but the way cargo-deny is currently implemented didn't lend itself to doing that (easily at least), and I needed a targeted solution.

Thanks for accepting the PR, and let me know if I can help on the future change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants