-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation with luajit and 5.1 #480
Conversation
Looks like lua51 has errors:
|
Should we even continue supporting 5.1 realistically? I don't think I've ever seen anyone specifically use it. |
It's strange don't have the same errors |
@Foereaper Well, maybe not. But luajit is basically same as lua51 + some extensions. I suspect that the issue is here #define lua_rawlen(L, idx) \
- lua_objlen(L, idx);
+ lua_objlen(L, idx) The semicolon should be removed as its not a part of the macro we replace. The result of |
Then, in terms of "usage", LuaJit is much more widely used than Lua53 / Lua54 |
We can reduce the amount of lua versions we support. |
This works with LuaJit : c2bf6da |
I don't think 5.3 and 5.4 is widely used in the Lua community in general, they don't really give us anything that is super necessary so they could probably be dropped. I think 5.2 and LuaJIT are probably the more relevant ones to support, jit for obvious reasons and 5.2 for module support. |
Luajit support really seems to me to be important and more "necessary" just when you see the performance there's not much to add. (https://eklausmeier.wordpress.com/2020/05/14/performance-comparison-pallene-vs-lua-5-1-5-2-5-3-5-4-vs-c/) For Lua 5.3 and Lua 5.4 in any case, you'll need to update AIO and a lot of tools / scripts that use the bit system for example, which is now native. I think a lot of people stuck to Lua 5.2 for their projects, since it was the "default" version of Eluna. |
I tried fixing 5.1 support, and the more I fix the more is missing to fix it properly. I think we should at the very least drop 5.1 support at this point. |
For now the compilation is fixed. |
No description provided.