[ADD][BR1228][T24770]Extra time application #206

XXXXLM · 2017-12-14T10:58:28Z

No description provided.

elicoidal · 2017-12-15T07:58:48Z

Is it ready to be reviewed @Miya609 ?

XXXXLM · 2017-12-15T08:03:19Z

@eric Caudal not yet.I am make test more perfect.

------------------ Original ------------------ From: "Eric @ Elico Corp"<[email protected]>; Date: Fri, Dec 15, 2017 03:58 PM To: "Elico-Corp/odoo-addons"<[email protected]>; Cc: "Miya Xing-Elico corp"<[email protected]>; "Mention"<[email protected]>; Subject: Re: [Elico-Corp/odoo-addons] [ADD][BR1228][T24770]Extra timeapplication (#206) Is it ready to be reviewed @Miya609 ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

lonelysun

please fix

lonelysun · 2017-12-18T02:46:35Z

extra_time_application/__manifest__.py

+
+{
+    'name': 'Extra Time Application',
+    'version': '10.0.1.0.0',


why version is '10.0.1.0.0'?

lonelysun · 2017-12-18T02:57:06Z

extra_time_application/models/project_task_inherit.py

+        user = self.env.user
+        is_exist = user.has_group(
+            'extra_time_application.group_project_task_manager')
+        remaining = self.remaining_hours


adapt api.multi

lonelysun · 2017-12-18T06:53:18Z

extra_time_application/models/project_task_inherit.py

+                        'The task have no enough time, '
+                        'please Apply for more extra time'
+                    ))
+            if not vals.get('project_id.is_modified'):


what't this?

lonelysun · 2017-12-18T06:54:27Z

extra_time_application/models/task_timesheet.py

+    submit_user_id = fields.Many2one(
+        'res.users', 'Applicant', help='Applicant',
+    )
+    task_no = fields.Many2one('project.task', 'Task No', help='Task No')


m2o field should be named xxx_id

elicoidal

Too many simple mistakes

elicoidal · 2017-12-19T01:19:04Z

extra_time_application/LICENSE

@@ -0,0 +1,11 @@
+Elico Proprietary License v1.0


No need this file. This module can be AGPLv3

elicoidal · 2017-12-19T01:19:40Z

extra_time_application/README.rst

+------------
+
+* Miya Xing <[email protected]>
+


add the other contributors (Eric, Sebastien, Hulk)

elicoidal · 2017-12-19T01:20:50Z

extra_time_application/__manifest__.py

+
+{
+    'name': 'Extra Time Application',
+    'version': '10.0.0.0.0',


Actually @lonelysun 10.0.1.0.0 should be the correct start (first version of the module in v10)

elicoidal · 2017-12-19T01:21:41Z

extra_time_application/__manifest__.py

+    'version': '10.0.0.0.0',
+    'author': "Elico Corp",
+    'website': 'https://www.elico-corp.com',
+    'license': 'Other proprietary',


You are not being logical/consistent: here it says proprietary but everywhere you say AGPL!
license should be AGPLv3

elicoidal · 2017-12-19T01:22:40Z

extra_time_application/models/project_task_inherit.py

+                    log.env['extra.time.application'].create({
+                        'submit_user_id': user.id,
+                        'task_id': log.id,
+                        'reason': 'Automaticity create From PM or Reviewer',


Automatically created from PM or Reviewer

elicoidal · 2017-12-19T01:26:28Z

extra_time_application/tests/test_extra_time_wizard.py

@@ -0,0 +1,29 @@
+# -*- coding: utf-8 -*-
+# © 2017 Elico Corp (www.elico-corp.com)
+# Elico Proprietary License v1.0.


license is AGPL (everywhere)

elicoidal · 2017-12-19T01:27:17Z

extra_time_application/tests/test_project_task_save.py

+        self.task_1.write(vals_2)
+        try:
+            self.task_2.write(vals_2)
+        except Exception:


I am surprised: should not this trigger an error so that the test fails?

elicoidal · 2017-12-19T01:28:04Z

extra_time_application/tests/test_project_task_save.py

+        self.sub_extra_time = 0
+        self.timesheet_ids = self.env['account.analytic.line'].write([[
+            0, False, {
+                'date_time': '2017-12-15',


For all date, I would suggest to use today() and relative dates in the future today()+2 for example

elicoidal · 2017-12-19T01:28:34Z

extra_time_application/wizard/extra_time_application_wizard.py

+    @api.multi
+    def subscribe(self):
+        user = self.env.user
+        is_exist = user.has_group(


Improve the variable name

elicoidal · 2017-12-19T01:28:45Z

extra_time_application/wizard/extra_time_application_wizard.py

+            self.env['extra.time.application'].create({
+                'submit_user_id': self.submit_user_id.id,
+                'task_id': self.task_id.id,
+                'reason': 'Automaticity create From PM or Reviewer',


Automatically created from

XXXXLM · 2017-12-19T09:15:57Z

@elicoidal No need for draft state,and I fix other error,could you review it?

elicoidal · 2017-12-19T09:25:14Z

Travis still failing it seems

elicoidal · 2017-12-19T09:27:27Z

extra_time_application/models/project_project_inherit.py

+class ProjectProjectInherit(models.Model):
+    _inherit = 'project.project'
+
+    is_modified = fields.Boolean()


What is this for?
This column is never assigned and has no title.
What is the usage?
cc @lonelysun

XXXXLM · 2017-12-20T02:45:18Z

@elicoidal Please review it.

elicoidal · 2017-12-20T04:21:05Z

Travis is still failing
@Miya609 @lonelysun

lonelysun · 2017-12-20T04:23:16Z

I’m finding the reason now. Hulk Liu [Developer] Phone: +86 186 1691 1517 (Cell), +86 21 6211 8017/27/37 (Office) Elico Shanghai (Hong Kong/Shenzhen/Singapore) <http://www.elico-corp.com/> Odoo Gold Partner // Best Odoo Partner APAC 2014 and 2016 Sent by Shanghai Elico Limited - 上海寰享网络科技有限公司 <http://www.elico-corp.com/> using Odoo <https://www.odoo.com/> about Timesheet Week 47 <https://www.elico-corp.com/web?db=elico_stable#action=mail.action_mail_redirect&login=hulk.liu%40elico-corp.com&message_id=417889>

… automatic create a extra time record

XXXXLM · 2018-01-12T09:02:37Z

@seb-elico Could you tell me the reason that why the travis not working?

lonelysun · 2018-03-21T04:04:06Z

move to #210

XXXXLM added 5 commits December 12, 2017 17:07

[ADD][BR1228][T24770]extra_time_application

aba0ace

[FIX]make module more intact

126fc0f

[ADD]add test

1135ecb

[FIX]travis error

4ba428e

[FIX]fix travis error

c908843

lonelysun suggested changes Dec 18, 2017

View reviewed changes

XXXXLM added 2 commits December 18, 2017 16:36

[FIX]fix test error and some logic error

97ded94

[FIX]add lisence file and fix test error

6adecce

elicoidal requested changes Dec 19, 2017

View reviewed changes

XXXXLM added 5 commits December 19, 2017 13:57

[IMP]make some hint morespecific and fix some test error

7bd17b5

[FIX]travis error

c64767c

[FIX]travis error

b7f03f6

[FIX]license and init

2a88b15

[IMP]add message_post

223aceb

elicoidal reviewed Dec 19, 2017

View reviewed changes

XXXXLM added 3 commits December 19, 2017 17:50

[FIX]add field instruction

05012ca

[DEL]del tests file to test

4896596

[IMP]add test file

794b7b8

[FIX]the bug that when input timesheet and edit remainig_hours do not…

e18439d

… automatic create a extra time record

lonelysun mentioned this pull request Mar 21, 2018

[ADD][BR1228][T24770]Extra time application #210

Open

lonelysun closed this Mar 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD][BR1228][T24770]Extra time application #206

[ADD][BR1228][T24770]Extra time application #206

XXXXLM commented Dec 14, 2017

elicoidal commented Dec 15, 2017

XXXXLM commented Dec 15, 2017 via email

lonelysun left a comment

lonelysun Dec 18, 2017

lonelysun Dec 18, 2017

lonelysun Dec 18, 2017

lonelysun Dec 18, 2017

elicoidal left a comment

elicoidal Dec 19, 2017

elicoidal Dec 19, 2017

elicoidal Dec 19, 2017

elicoidal Dec 19, 2017

elicoidal Dec 19, 2017

elicoidal Dec 19, 2017

elicoidal Dec 19, 2017

elicoidal Dec 19, 2017

elicoidal Dec 19, 2017

elicoidal Dec 19, 2017

XXXXLM commented Dec 19, 2017

elicoidal commented Dec 19, 2017

elicoidal Dec 19, 2017

XXXXLM commented Dec 20, 2017

elicoidal commented Dec 20, 2017

lonelysun commented Dec 20, 2017 via email

XXXXLM commented Jan 12, 2018

lonelysun commented Mar 21, 2018

[ADD][BR1228][T24770]Extra time application #206

[ADD][BR1228][T24770]Extra time application #206

Conversation

XXXXLM commented Dec 14, 2017

elicoidal commented Dec 15, 2017

XXXXLM commented Dec 15, 2017 via email

lonelysun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elicoidal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

XXXXLM commented Dec 19, 2017

elicoidal commented Dec 19, 2017

Choose a reason for hiding this comment

XXXXLM commented Dec 20, 2017

elicoidal commented Dec 20, 2017

lonelysun commented Dec 20, 2017 via email

XXXXLM commented Jan 12, 2018

lonelysun commented Mar 21, 2018