Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nemo eval in containers with TransformerEngine > 1.10 won't error #2621

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: nemo eval in containers with TransformerEngine > 1.10 won't error #2621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lm_eval/models/nemo_lm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,25 @@ def _synced_build_tokenizer(self):
model_class._original_build_tokenizer = model_class._build_tokenizer
model_class._build_tokenizer = _synced_build_tokenizer

extra_restore_kwargs = {}
try:
from megatron.core.dist_checkpointing.validation import StrictHandling
# TransformerEngine has changed the way metadata is stored in checkpoints after
# v1.10. This change requires users to relax the strictness when checkpoint restoring.
# See https://docs.nvidia.com/nemo-framework/user-guide/24.12/knownissues.html#known-issues
# for more details. For convenience, relax strictness by default if the enum is available to
# log all mismatches.
extra_restore_kwargs['strict'] = StrictHandling.LOG_ALL
except:
pass

model = model_class.restore_from(
restore_path=model_to_load_path.as_posix(),
trainer=trainer,
override_config_path=override_config,
save_restore_connector=save_restore_connector,
map_location=f"cuda:{trainer.local_rank}",
**extra_restore_kwargs
)

model.freeze()
Expand Down