Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags for setting fee limits for swaps (L2 routing) #79

Merged
merged 3 commits into from
May 8, 2024

Conversation

Jossec101
Copy link
Contributor

This pull request adds two new flags, limitQuoteFees and limitFeesL2, to set fee limits for swaps. The limitQuoteFees flag sets the max fee ratio for swaps quotes, while the limitFeesL2 flag sets the fee ratio for swaps max routing fee. These flags allow for more control over the fees associated with swaps.

…e limitQuoteFees flag sets the fee ratio for swaps quotes, while the limitFeesL2 flag sets the fee ratio for swaps max routing fee.
@Jossec101 Jossec101 changed the title Add flags for setting fee limits for swaps Add flags for setting fee limits for swaps (L2 routing) May 8, 2024
@Jossec101 Jossec101 requested a review from markettes May 8, 2024 17:04
Copy link
Contributor

@markettes markettes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

provider/loop_provider.go Show resolved Hide resolved
@Jossec101 Jossec101 merged commit 52fc54a into main May 8, 2024
1 check passed
@Jossec101 Jossec101 deleted the add-l2-max-routing-fee branch May 8, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants