Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set max limit for fees #59

Merged
merged 5 commits into from
Nov 17, 2023
Merged

fix: set max limit for fees #59

merged 5 commits into from
Nov 17, 2023

Conversation

markettes
Copy link
Contributor

No description provided.

@markettes markettes linked an issue Nov 14, 2023 that may be closed by this pull request
Liquidator swaps max fees are not limited #58
Closed
@markettes markettes marked this pull request as ready for review November 14, 2023 19:15
@markettes
fix(loop_provider.go): change limitFees variable to read from environ…
9ec15ec 
…ment variable LIMITFEES instead of using viper to improve flexibility and configuration options

test(loop_provider_test.go): set LIMITFEES environment variable to "0.1" for testing purposes
Jossec101
Jossec101 requested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Jossec101 Jossec101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing loop out quotes limit on all fees

@Jossec101 Jossec101 merged commit cad882e into main Nov 17, 2023
1 check passed
@Jossec101 Jossec101 deleted the 58-liquidator-swaps-max-fees-are-not-limited branch November 17, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jossec101 Jossec101 Jossec101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Liquidator swaps max fees are not limited
2 participants
@markettes @Jossec101