Adding auth to grpc ng #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jossec101
previously approved these changes
Oct 16, 2023
gcaracuel
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a GRPC interceptor to NodeGuard client to send the proper auth header.
https://www.notion.so/clovrlabs/Phase-3-Live-4a570b5e538b4a0aa4b6980007d68977?p=80f65dac3561479aad3e7c10158d4eaf&pm=c
Regarding the value of new environment variable
NODEGUARD_API_KEYi will automatically create this data for development purposes in NodeGuard database :). Please, wait for this changes to come!I introduced a couple of changes as well:
getConnmethod. We have several grpc options which are common to all of our clients but only NG needed auth so far. I used this pattern to make it optional and customizable per client, keeping the base options for everyone..envfile :) should be the agnostic way to go! Please,vscodeusers update your configs to add new variable.