Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable and fix for windows build by cmake project file #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qwerity
Copy link

@qwerity qwerity commented Oct 19, 2024

Enabled by default cmake project files.
Also fixed the Windows build.
Tested for VS2019/VS2022.

@jgriffiths
Copy link
Contributor

jgriffiths commented Oct 20, 2024

Hi @qwerity

Thanks for this! Can I ask you to make the following changes?

  • The secp update should be in its own commit. I'm about to update master shortly so I will update secp there and you can rebase this PR from master.
  • Please remove the indentation from the #include line protected by #ifndef
  • Please either remove the cmake file renaming or add it as a separate commit. We currently have a downstream fork of wally that uses cmake and are in the process of merging them. Until that is complete (i.e. they can switch to our upstream version here) we are keeping the cmake files renamed so they can continue to take our changes. Once that is done we will rename the files.

edit: master is now updated if you'd like to rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants