Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting from VerifyAmounts #1254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Improve error reporting from VerifyAmounts

b14e739
Select commit
Loading
Failed to load commit list.
Open

Improve error reporting from VerifyAmounts #1254

Improve error reporting from VerifyAmounts
b14e739
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Cirrus CI / macOS 10.14 [gui, no tests] [focal] failed Aug 1, 2023 in 20m 27s

Task Summary

Instruction ci failed in 19:18

Details

✅ 00:32 clone
✅ 00:00 depends_sdk
✅ 00:27 merge_base
✅ 00:00 ccache
✅ 00:05 depends_built
❌ 19:18 ci

                                              ^
test/blind_tests.cpp:347:21: error: invalid argument type 'const std::string' (aka 'const basic_string<char, char_traits<char>, allocator<char> >') to unary expression
        BOOST_CHECK(!VerifyAmounts(inputs, CTransaction(txtemp), nullptr, false));
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/tools/old/interface.hpp:83:6: note: expanded from macro 'BOOST_CHECK'
    (P), BOOST_TEST_STRINGIZE( P ), CHECK, CHECK_PRED, _ )
     ^
/tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/tools/old/interface.hpp:68:61: note: expanded from macro 'BOOST_TEST_TOOL_IMPL'
        BOOST_JOIN( BOOST_TEST_TOOL_PASS_PRED, frwd_type )( P, ARGS ),          \
                                                            ^
/tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/tools/old/interface.hpp:51:47: note: expanded from macro 'BOOST_TEST_TOOL_PASS_PRED2'
#define BOOST_TEST_TOOL_PASS_PRED2( P, ARGS ) P
                                              ^
test/blind_tests.cpp:366:21: error: invalid argument type 'const std::string' (aka 'const basic_string<char, char_traits<char>, allocator<char> >') to unary expression
        BOOST_CHECK(!VerifyAmounts(inputs, CTransaction(txtemp), nullptr, false));
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/tools/old/interface.hpp:83:6: note: expanded from macro 'BOOST_CHECK'
    (P), BOOST_TEST_STRINGIZE( P ), CHECK, CHECK_PRED, _ )
     ^
/tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/tools/old/interface.hpp:68:61: note: expanded from macro 'BOOST_TEST_TOOL_IMPL'
        BOOST_JOIN( BOOST_TEST_TOOL_PASS_PRED, frwd_type )( P, ARGS ),          \
                                                            ^
/tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/tools/old/interface.hpp:51:47: note: expanded from macro 'BOOST_TEST_TOOL_PASS_PRED2'
#define BOOST_TEST_TOOL_PASS_PRED2( P, ARGS ) P
                                              ^
test/blind_tests.cpp:368:21: error: invalid argument type 'const std::string' (aka 'const basic_string<char, char_traits<char>, allocator<char> >') to unary expression
        BOOST_CHECK(!VerifyAmounts(inputs, CTransaction(txtemp), nullptr, false));
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/tools/old/interface.hpp:83:6: note: expanded from macro 'BOOST_CHECK'
    (P), BOOST_TEST_STRINGIZE( P ), CHECK, CHECK_PRED, _ )
     ^
/tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/tools/old/interface.hpp:68:61: note: expanded from macro 'BOOST_TEST_TOOL_IMPL'
        BOOST_JOIN( BOOST_TEST_TOOL_PASS_PRED, frwd_type )( P, ARGS ),          \
                                                            ^
/tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/tools/old/interface.hpp:51:47: note: expanded from macro 'BOOST_TEST_TOOL_PASS_PRED2'
#define BOOST_TEST_TOOL_PASS_PRED2( P, ARGS ) P
                                              ^
In file included from test/blind_tests.cpp:13:
In file included from /tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/unit_test.hpp:18:
In file included from /tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/test_tools.hpp:46:
In file included from /tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/tools/old/impl.hpp:20:
/tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/tools/assertion_result.hpp:57:74: error: invalid argument type 'const std::__1::basic_string<char>' to unary expression
    assertion_result( BoolConvertable const& pv_ ) : p_predicate_value( !!pv_ ) {}
                                                                         ^~~~
test/blind_tests.cpp:75:9: note: in instantiation of function template specialization 'boost::test_tools::assertion_result::assertion_result<std::__1::basic_string<char> >' requested here
        BOOST_CHECK(VerifyAmounts(inputs, CTransaction(tx3), nullptr, false));
        ^
/tmp/cirrus-ci-build/depends/x86_64-apple-darwin18/include/boost/test/tools/old/interface.hpp:83:5: note: expanded from macro 'BOOST_CHECK'
    (P), BOOST_TEST_STRINGIZE( P ), CHECK, CHECK_PRED, _ )
    ^
18 errors generated.
make[2]: *** [Makefile:18296: test/test_bitcoin-blind_tests.o] Error 1
make[2]: Leaving directory '/tmp/cirrus-ci-build/ci/scratch/build/elements-x86_64-apple-darwin18/src'
make[1]: *** [Makefile:18578: all-recursive] Error 1
make[1]: Leaving directory '/tmp/cirrus-ci-build/ci/scratch/build/elements-x86_64-apple-darwin18/src'
make: *** [Makefile:829: all-recursive] Error 1