Integrate zcash-light-client-ffi version 0.9.0 #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables us to simplify the FFI backend.
Includes: - Initialization changes to enable log filter customization. We now connect the Rust log level to the Swift log level, and always run other Rust initialization steps. - ZIP 320 support (TEX addresses).
- API refactored to Combine's CurrentValueSubject refresh-rate - FiatCurrencyResult is now Equatable refresh-rates - cleanup refresh-rates - The API has been refactored to follow the same principles as for state and events. - Review comments addressed refresh-rates - The API has been extended to send a result of the operation, success or failure refresh-rates - bugfix of the try vs try? refresh-rates - reverted the error state Update CHANGELOG.md - changelog updated
Co-authored-by: Jack Grigg <[email protected]>
refresh-rates
- The API has been refactored to carry state and always broadcast a value, even in case of failed request always-return-value - ignore refresh request when one is already in flight always-return-value - ensure tor client is initialized always-return-value - don't pass nil value always-return-value - final touch, the tor initialization is sligthly more controlled and error potentially propagated.
always-return-value
- comments addressed
comments-fixed
…exchange-rates Migrate to first pre-release of FFI 0.9.0
- RustBackend extended for the new 2 rust methods 'transactionDataRequests' and 'setTransactionStatus' - lightwalletservice extended to add a new method 'getTaddressTxids' - Enhance action has been refactored to handle transactionDataRequests [#1475] Adopt transaction data requests - fixes [#1475] Adopt transaction data requests - Error codes for specific rust and service errors defined - Fix for the txId [#1475] Adopt transaction data requests - Checkpoints added - Code cleanup [#1475] Adopt transaction data requests - bugfixes in the ffi [#1475] Adopt transaction data requests - FFI with fixes [#1475] Adopt transaction data requests - Another FFI update with fixes, this time the final [#1475] Adopt transaction data requests - Fix for the not recognized state of the transaction for FetchTransaction(txId:) [#1475] Adopt transaction data requests - Code cleaned up and polished [#1475] Adopt transaction data requests - Changelog updated [#1475] Adopt transaction data requests - DemoApp settings reverted
- Refactor of the logic based on the review, the determination of the calls can't be based on block height but actual response from grpc [#1475] Adopt transaction data requests - fixes [#1475] Adopt transaction data requests - Changes made on pairing call [#1475] Adopt transaction data requests - fixes [#1475] Adopt transaction data requests - code cleanup [#1475] Adopt transaction data requests - FFI bumped to the latest version with fixes [#1475] Adopt transaction data requests - comments removed [#1475] Adopt transaction data requests - endHeight for spendsFromAddress reduced by 1
- SpendsFromAddress endHeight is an optional UInt32 [#1475] Adopt transaction data requests - ignoring the getSubtreeRoots error for now so I can test tex send [#1475] Adopt transaction data requests - ignoring error of getSubtreeRoots [#1475] Adopt transaction data requests - reverting the DemoAppConfig [#1475] Adopt transaction data requests - FFI dependency set to 0.9.0 [#1475] Adopt transaction data requests - Handling of unknown (code 2) errors as a workaround
…requests [#1475] Adopt transaction data requests
nuttycom
commented
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer