-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1202] Adopt latest FFI changes in SbS pre-release branch #1203
Closed
LukasKorba
wants to merge
15
commits into
Electric-Coin-Company:feature/DAG-sync
from
LukasKorba:1202-Adopt-latest-FFI-changes-in-SbS-pre-release-branch
Closed
[#1202] Adopt latest FFI changes in SbS pre-release branch #1203
LukasKorba
wants to merge
15
commits into
Electric-Coin-Company:feature/DAG-sync
from
LukasKorba:1202-Adopt-latest-FFI-changes-in-SbS-pre-release-branch
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - demo app config cleaned up [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - offline tests fixed
draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated
…m lightwalletd - update chain tip action added [Electric-Coin-Company#1167] Step 3 - Download chain tip metadata from lightwalletd - roots removed from the ActionContext [Electric-Coin-Company#1167] Step 3 - Download chain tip metadata from lightwalletd - fallback to linear sync until next step is implemented [Electric-Coin-Company#1167] Step 3 - Download chain tip metadata from lightwalletd - offline tests fixed
…om the wallet database - initial action in place - verify loop WIP [Electric-Coin-Company#1169] Step 5 -Get the suggested scan ranges from the wallet database - firstUnenhancedHeight fix [Electric-Coin-Company#1169] Step 5 -Get the suggested scan ranges from the wallet database - first working version implemented - download, scan and enhance actions are dependent on the context values only
- cleaned up the code - ScanAlgorithm enum added to the SDK - preferred sync algorithm set to .linear as default but can be changed to Spend before Sync as the Initializer.init parameter [Electric-Coin-Company#1188] Working prototype of SbS - error codes for failure states in the SbS State Machine changes added [Electric-Coin-Company#1188] Working prototype of SbS (Electric-Coin-Company#1192) - offline tests fixed
- RewindAction added - rust's isContinuityError() emulated on iOS side - verify scan range is now properly handled with rewind as well as check for continuity error [Electric-Coin-Company#1189] Implement continuity check and RewindAction (Electric-Coin-Company#1195) - TODO cleanup
- the value 65536 set only for testnet
…rking-prototype-of-SbS 1188 working prototype of SbS
…plement-continuity-check-and-RewindAction [Electric-Coin-Company#1189] implement continuity check and rewind action
…ndle-production-GetSubtreeRootsArg [Electric-Coin-Company#1180] handle production get subtree roots arg
…d before Sync - the computation of progress changed, the total range is computed, that way it works for any kind of sync algorithm - the progress depends on finished scan action, whenever it processes some blocks, it's counted up - the final progress is a ratio between these new values
…rrect-computation-of-progress-for-Spend-before-Sync [Electric-Coin-Company#1181] Correct computation of progress for Spend before Sync
Bumps [github.com/apple/swift-nio-extras](https://github.com/apple/swift-nio-extras) from 1.12.1 to 1.19.0. - [Release notes](https://github.com/apple/swift-nio-extras/releases) - [Commits](apple/swift-nio-extras@1.12.1...1.19.0) --- updated-dependencies: - dependency-name: github.com/apple/swift-nio-extras dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
- the priorities for log levels have been updated [Electric-Coin-Company#1196] Check logging level priorities - changelog updated
…ase branch - dependency update
LukasKorba
force-pushed
the
feature/DAG-sync
branch
from
August 18, 2023 11:09
819b5f3
to
62945ec
Compare
Invalid PR |
LukasKorba
deleted the
1202-Adopt-latest-FFI-changes-in-SbS-pre-release-branch
branch
August 31, 2023 05:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1202
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer