-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1165] Steps 1 & 2 - Download note commitment tree data from lightwalletd #1174
Conversation
draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - demo app config cleaned up
3fd68f8
to
f2622c0
Compare
…ata from lightwalletd (Electric-Coin-Company#1174) - offline tests fixed
draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - demo app config cleaned up [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - offline tests fixed
195911b
to
fda0fed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good to me.
Not sure if this is also the iOS side related, but on the Android, we also need to recognize the error which came from the getSubtreeRoot
to retry in case of connectivity issue and not just state that the node does not support the non-linear sync mechanism later, as this action is not part of the regular sync loop.
Good catch, I filed the issue #1179 |
00223f2
into
Electric-Coin-Company:feature/DAG-sync
draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - demo app config cleaned up [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - offline tests fixed
draft [#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [#1165] Step 1 - Download note commitment tree data from lightwalletd (#1174) - demo app config cleaned up [#1165] Step 1 - Download note commitment tree data from lightwalletd (#1174) - offline tests fixed
draft [#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [#1165] Step 1 - Download note commitment tree data from lightwalletd (#1174) - demo app config cleaned up [#1165] Step 1 - Download note commitment tree data from lightwalletd (#1174) - offline tests fixed
draft [#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [#1165] Step 1 - Download note commitment tree data from lightwalletd (#1174) - demo app config cleaned up [#1165] Step 1 - Download note commitment tree data from lightwalletd (#1174) - offline tests fixed
draft [#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [#1165] Step 1 - Download note commitment tree data from lightwalletd (#1174) - demo app config cleaned up [#1165] Step 1 - Download note commitment tree data from lightwalletd (#1174) - offline tests fixed
draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - demo app config cleaned up [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - offline tests fixed
draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - demo app config cleaned up [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - offline tests fixed
draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - demo app config cleaned up [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - offline tests fixed
draft [#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [#1165] Step 1 - Download note commitment tree data from lightwalletd (#1174) - demo app config cleaned up [#1165] Step 1 - Download note commitment tree data from lightwalletd (#1174) - offline tests fixed
draft [#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [#1165] Step 1 - Download note commitment tree data from lightwalletd (#1174) - demo app config cleaned up [#1165] Step 1 - Download note commitment tree data from lightwalletd (#1174) - offline tests fixed
Closes #1165
Closes #1166
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer