forked from kbrighton/chiaki
-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
38d633f
commit 0f12a63
Showing
5 changed files
with
18 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f12a63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, the PS sends out legal range and not data range luma? That surprises me, I would have expected remote play to send data range.
0f12a63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tbh I don't have any idea what I did here. I went for the fastest, most braindead fix I could come up with to continue playing Bloodborne asap. So I am deeply sorry for the abomination this may be.
0f12a63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those conversions are correct for legal range luma - https://www.lightillusion.com/data_legal_levels.html
I'm just surprise that the console is sending legal range luma. There might be some undesired conversion happening earlier in the pipeline, or possibly an as yet undocumented parameter when requesting the stream.
I just upgraded from PS4 to PS5 and only recently discovered chiaki - Is this something that was working OK and was broken by a PlayStation update, or has it always been problematic?
0f12a63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, looks like the console has always been that way - but whatever you did at aedb17b#diff-60660f571de143f23e1f2575ee8f83df4c6a4d0712720ed41d07ad404a8f67bb reverted this routine to a a very old (and apparently broken) state
0f12a63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik, chiaki has had problems with inaccurate color for quite a while (if not since the beginning).
I happened to notice yellows were really off compared to the official Remote Play app, so I tried different conversions until I found one that looked better. But I have no idea how things really work, what the console really sends, or color theory in general.
Any input will be appreciated.
0f12a63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could try replicating that same color tone using Nvidia's board:
chiaki/gui/src/avopenglwidget.cpp
Line 64 in 0f12a63
I tested this patch of yours, and it's perfect! Can you apply the fix for nvidia?
My test, in the "decode" of chiaki, it only works if I leave it in "none" If I use vdpau or CUDA, the yellowing still persists.
0f12a63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please make a build for switch? i tried to do it myself but cmake sucks