bug fix for NaN giving silly values

EdwardRaff · May 31, 2016 · e133759 · e133759
1 parent 4b19445
commit e133759
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/JSAT/src/jsat/classifiers/trees/DecisionStump.java b/JSAT/src/jsat/classifiers/trees/DecisionStump.java
@@ -911,7 +911,7 @@ else if(i > DPs.size()-minResultSplitSize-nans)
                             thisSplitSqrdErr = Double.NEGATIVE_INFINITY;
                     }
                     //Now compare what weve done
-                    if(thisSplitSqrdErr < lowestSplitSqrdError.get())
+                    if(thisSplitSqrdErr >= 0 && thisSplitSqrdErr < lowestSplitSqrdError.get())//how did we get -Inf?
                     {
                         synchronized(bestSplit)
                         {

diff --git a/JSAT/test/jsat/classifiers/trees/RandomForestTest.java b/JSAT/test/jsat/classifiers/trees/RandomForestTest.java
@@ -218,7 +218,7 @@ public void testClone()
             RandomForest instance = new RandomForest();
 
             ClassificationDataSet t1 = FixedProblems.getSimpleKClassLinear(100, 3);
-            ClassificationDataSet t2 = FixedProblems.getSimpleKClassLinear(100, 6);
+            ClassificationDataSet t2 = FixedProblems.getSimpleKClassLinear(100, 4);
             if(useCatFeatures)
             {
                 t1.applyTransform(new NumericalToHistogram(t1));