fix HTML output of timeline descriptions #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by looking for text recursively
|
pinging @halhosar and @daniel-jettka for review :) |
halhosar
approved these changes
Oct 16, 2023
|
If this is this intended output, then it looks fine to me... :-) @peterstadler
Added this in the time line form:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #168 by updating an XPath predicate to recursively look for text nodes within an
<mei:desc>. NB, there's a related issue (that surfaced here) in that the MerMEId creates invalid MEI by adding an<mei:p>within<mei:desc>. Yet, I think the proposed fix is still valid since there are other child elements allowed within<mei:desc>that also might fool the original XPath expression.