Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(stale): create stale.yml workflow #7053

Merged
merged 15 commits into from
Sep 13, 2022
Merged

ci(stale): create stale.yml workflow #7053

merged 15 commits into from
Sep 13, 2022

Conversation

davorpa
Copy link
Member

@davorpa davorpa commented Sep 2, 2022 •
edited
Loading

What does this PR do?

Improve repo

For resources

Description

Current Configuration:

  • Run as diaryhourly cron or also manually
  • 30 60 days elapsed until stale
  • 7 30 days more to close that staled issue/PRs
  • Each step is automanaged with labels: stale, stale: closed. Some exemptions like discussions, reviews or pinnings

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa
ci(stale): create stale.yml workflow
7a60136 
- Treat issues and PRs separately
- At the end, generate a cross-linked summary with all processed issues/PRs
@davorpa davorpa added New Feature New feature / enhancement / translation... 👥 discussion This Repo is guided by its community! Let's talk! 👀 Needs Review Is this really a good resource? Reviews requested. 🤖 automation Automated tasks done by workflows or bots labels Sep 2, 2022
@davorpa davorpa self-assigned this Sep 2, 2022
@davorpa davorpa marked this pull request as ready for review September 2, 2022 09:11
@eshellman
Copy link
Collaborator

as we haven't had any autoclose action, I think it would be easier to get used to if the periods were longer. - 60 days to stale, the 30 days to autoclose.

@davorpa

This comment was marked as outdated.

Sign in to view
@LuigiImVector LuigiImVector mentioned this pull request Sep 2, 2022
Closed
@davorpa davorpa mentioned this pull request Sep 2, 2022
Closed
@davorpa davorpa marked this pull request as draft September 3, 2022 21:44
@ghost

This comment was marked as off-topic.

Sign in to view
@davorpa davorpa marked this pull request as ready for review September 6, 2022 00:31
@davorpa
Copy link
Member Author

davorpa commented Sep 9, 2022

The actions/stale v5 has an issue where updates by the GitHub Actions bot are recognized as updates. This causes the bot to not work as intended as the Stale label will be removed.

This issue has already been reported at: actions/stale#795

Downgrade the actions/stale package to v4 until the bug has been fixed upstream?

@davorpa davorpa marked this pull request as draft September 9, 2022 04:51
@davorpa davorpa added the question Needs clarification by involved users / reviewers label Sep 9, 2022
@LuigiImVector
Copy link
Member

Downgrade the actions/stale package to v4 until the bug has been fixed upstream?

if it doesn't involve other problems yes

@davorpa
Copy link
Member Author

davorpa commented Sep 9, 2022 •
edited
Loading

Downgrade the actions/stale package to v4 until the bug has been fixed upstream?

Maybe wait to patch is released in v5.0.2... actions/stale#816. It seems work. no actions here is needed since we use a major version in a project mantained frecuently

@davorpa
chore: cron back again every 6 hours o'clock...
0cc90eb 
Reverts commit dc44e45
@davorpa
chore: refactor workflow to have only one job but one step for issues…
26ea5aa 
… and other for PRs

New features:
- run on push over this workflow
- run manually have debug option to make a dry-run execution
- run scheduled is every 6 hours at o'clock
- Summary report is in table format instead of list items
@davorpa
Copy link
Member Author

davorpa commented Sep 11, 2022 •
edited
Loading

As posted in #7053 (comment), this workflow has been refactored (commit 26ea5aa) to have only one job but one step for issues and other for PRs

Current features:

  • run on push over this workflow
  • run manually have debug option to make a dry-run execution
  • run scheduled is every 6 hours at o'clock
  • ratio stale/closed of 60/30
  • Summary report is in table format instead of list items

Tests with details at:

@davorpa davorpa removed the question Needs clarification by involved users / reviewers label Sep 11, 2022
@davorpa davorpa marked this pull request as ready for review September 11, 2022 12:20
@LuigiImVector
Copy link
Member

  • run scheduled is every 6 hours at o'clock

why every 6 hours? I think it's useless to run it so often, it would just make it more complex to find summaries with useful information in them. I propose to run the workflow once a day/week.

@davorpa
Copy link
Member Author

davorpa commented Sep 12, 2022

  • run scheduled is every 6 hours at o'clock

why every 6 hours? I think it's useless to run it so often, it would just make it more complex to find summaries with useful information in them. I propose to run the workflow once a day/week.

I'll see once a day well. It is the recomended cron according to the config examples https://github.com/actions/stale/blob/main/.github/workflows/stale.yml. To make test use the extra manual run.

LuigiImVector
LuigiImVector approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@LuigiImVector LuigiImVector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LuigiImVector LuigiImVector added 🚀 ready to merge LGTM. Waiting for final approval and removed 👀 Needs Review Is this really a good resource? Reviews requested. labels Sep 13, 2022
@eshellman eshellman merged commit 8845486 into EbookFoundation:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuigiImVector LuigiImVector LuigiImVector approved these changes

Assignees

@davorpa davorpa

Labels
🤖 automation Automated tasks done by workflows or bots 👥 discussion This Repo is guided by its community! Let's talk! New Feature New feature / enhancement / translation... 🚀 ready to merge LGTM. Waiting for final approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davorpa @eshellman @LuigiImVector