Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested list cassette scrubbers #350

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Sep 19, 2024

Description

Either something changed with the cassettes saving or was never identified, but nested list scrubbers for a very specific niche set of responses weren't working due to a bad if statement. This fixes the problem and properly scrubs those.

Testing

I re-recorded the two offending cassettes.

Also re-ran the entire test suite with cassettes to ensure this shouldn't break anything else and it worked, will not commit those all though to save on git history.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team September 19, 2024 18:58
jchen293
jchen293 previously approved these changes Sep 19, 2024
nwithan8
nwithan8 previously approved these changes Sep 19, 2024
@Justintime50 Justintime50 merged commit 00de74f into master Sep 19, 2024
6 checks passed
@Justintime50 Justintime50 deleted the fix_nested_list_scrubbers branch September 19, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants