address nitpick

EasyPost · Jul 10, 2024 · 8bdfbdc · 8bdfbdc
1 parent bb1c123
commit 8bdfbdc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/EasyPost/Constant/Constants.php b/lib/EasyPost/Constant/Constants.php
@@ -20,7 +20,7 @@ abstract class Constants
         'FedexSmartpostAccount'
     ];
 
-    const UPS_ACCOUNT_TYPES_WITH_CUSTOM_WORKFLOWS = [
+    const UPS_OAUTH_ACCOUNT_TYPES = [
         'UpsAccount',
         'UpsMailInnovationsAccount',
         'UpsSurepostAccount'

diff --git a/lib/EasyPost/Service/CarrierAccountService.php b/lib/EasyPost/Service/CarrierAccountService.php
@@ -45,14 +45,14 @@ public function update(string $id, mixed $params): mixed
     {
         $carrierAccount = self::retrieve($id);
         $carrierAccountType = $carrierAccount['type'];
-        if (in_array($carrierAccountType, Constants::UPS_ACCOUNT_TYPES_WITH_CUSTOM_WORKFLOWS, true)) {
-            $updateUrl = 'upsOauthRegistration';
+        if (in_array($carrierAccountType, Constants::UPS_OAUTH_ACCOUNT_TYPES, true)) {
+            $className = 'UpsOauthRegistration';
             $params = [self::selectTopLayerKey($carrierAccountType) => $params];
         } else {
-            $updateUrl = 'carrierAccount';
+            $className = 'CarrierAccount';
             $params = [self::selectTopLayerKey($carrierAccountType) => $params];
         }
-        return self::updateResource($updateUrl, $id, $params);
+        return self::updateResource($className, $id, $params);
     }
 
     /**
@@ -111,7 +111,7 @@ private function selectCarrierAccountCreationEndpoint(string $carrierAccountType
     {
         if (in_array($carrierAccountType, Constants::CARRIER_ACCOUNT_TYPES_WITH_CUSTOM_WORKFLOWS, true)) {
             return '/carrier_accounts/register';
-        } else if (in_array($carrierAccountType, Constants::UPS_ACCOUNT_TYPES_WITH_CUSTOM_WORKFLOWS, true)) {
+        } else if (in_array($carrierAccountType, Constants::UPS_OAUTH_ACCOUNT_TYPES, true)) {
             return '/ups_oauth_registrations';
         }
 
@@ -126,7 +126,7 @@ private function selectCarrierAccountCreationEndpoint(string $carrierAccountType
      */
     private function selectTopLayerKey(string $carrierAccountType): string
     {
-        return in_array($carrierAccountType, Constants::UPS_ACCOUNT_TYPES_WITH_CUSTOM_WORKFLOWS, true)
+        return in_array($carrierAccountType, Constants::UPS_OAUTH_ACCOUNT_TYPES, true)
             ? 'ups_oauth_registrations'
             : 'carrier_account';
     }