feat: add fields to shipment_options required by LaserShip #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwithan8
approved these changes
Apr 13, 2024
Justintime50
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds fields used by LaserShipV2 carrier that were not previously present in the Go SDK. We are an existing customer of yours and have been using this custom patch in production to print LaserShip labels in non-trivial volumes for a while now.
Testing
Regression testing via existing unit tests (
make test) all pass successfully with our own API keys, and we have manually validated LaserShipV2 labels that were printed, as well as validating the createdshipmententities on EasyPost dashboard.Pull Request Type
Please select the option(s) that are relevant to this PR.