Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Cannot determine payment method when funding/deleting #214

Merged
merged 2 commits into from
Apr 10, 2024
Merged

[bug] Cannot determine payment method when funding/deleting #214

merged 2 commits into from
Apr 10, 2024

Conversation

nwithan8
Copy link
Contributor

@nwithan8 nwithan8 commented Apr 8, 2024 •
edited
Loading

Description

  • Use payment method object type when determining type for fund, delete functions

Testing

  • Update, add unit test to confirm "by object type" works to determine payment method type

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team April 8, 2024 22:48
@nwithan8 nwithan8 merged commit e67e951 into master Apr 10, 2024
9 checks passed
@nwithan8 nwithan8 deleted the payment_methods branch April 10, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50