Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add paginated children (beta) #206

Merged
merged 4 commits into from
Jan 4, 2024
Merged

[feat] Add paginated children (beta) #206

merged 4 commits into from
Jan 4, 2024

Conversation

nwithan8
Copy link
Contributor

Description

  • Add ListChildUsers and GetNextChildUserPage functions to User service
  • Fix a bad docstring

Testing

  • Add appropriate unit tests, cassettes

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc.)

@nwithan8 nwithan8 requested a review from a team December 13, 2023 19:37
@nwithan8 nwithan8 marked this pull request as draft December 15, 2023 21:21
@nwithan8 nwithan8 marked this pull request as ready for review January 4, 2024 19:56
jchen293
jchen293 reviewed Jan 4, 2024
View reviewed changes
user.go Show resolved Hide resolved
@nwithan8 nwithan8 requested a review from jchen293 January 4, 2024 21:24
@nwithan8 nwithan8 merged commit 82f1d92 into master Jan 4, 2024
9 checks passed
@nwithan8 nwithan8 deleted the children branch January 4, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50