Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep v4.0.0 release #204

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Prep v4.0.0 release #204

merged 3 commits into from
Dec 4, 2023

Conversation

jchen293
Copy link
Contributor

@jchen293 jchen293 commented Dec 4, 2023

Description

Prep v4.0.0 release with upgrade guide

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc.)

@jchen293 jchen293 requested a review from a team December 4, 2023 20:38
Justintime50
Justintime50 reviewed Dec 4, 2023
View reviewed changes
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
Justintime50
Justintime50 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always seem to get burned on the chicken vs egg problem when releasing a major version of Go... We'll need to determine how best to do it and document it this time if possible where we get the least resistance.

@jchen293 jchen293 merged commit 6f47eb6 into master Dec 4, 2023
9 checks passed
@jchen293 jchen293 deleted the prep_release branch December 4, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@nwithan8 nwithan8 nwithan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchen293 @nwithan8 @Justintime50